From 350fc5e6ed4d35638c6493e210dbe7a35b5fa099 Mon Sep 17 00:00:00 2001
From: Tom Ryder <tom@sanctum.geek.nz>
Date: Mon, 5 Aug 2013 13:30:14 +1200
Subject: More thorough quoting

---
 bash/bash_profile        | 4 ++--
 bash/bashrc              | 6 +++---
 git/gitconfig            | 4 ++--
 sh/profile               | 4 ++--
 sh/profile.d/keychain.sh | 4 ++--
 5 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/bash/bash_profile b/bash/bash_profile
index 3b391209..4594b77b 100644
--- a/bash/bash_profile
+++ b/bash/bash_profile
@@ -1,10 +1,10 @@
 # Source Bourne shell profile if it exists
 if [[ -r "$HOME/.profile" ]]; then
-    source $HOME/.profile
+    source "$HOME/.profile"
 fi
 
 # Source interactive Bash config if it exists
 if [[ -r "$HOME/.bashrc" ]]; then
-    source $HOME/.bashrc
+    source "$HOME/.bashrc"
 fi
 
diff --git a/bash/bashrc b/bash/bashrc
index 7924a7e1..45539977 100644
--- a/bash/bashrc
+++ b/bash/bashrc
@@ -32,9 +32,9 @@ if [[ -r /etc/bash_completion ]]; then
 fi
 
 # Load any supplementary scripts
-if [[ -d "$HOME/.bashrc.d" ]]; then
-    for file in $HOME/.bashrc.d/*; do
-        source $file
+if [[ -d "${HOME}/.bashrc.d" ]]; then
+    for file in "${HOME}/.bashrc.d"/*; do
+        source "$file"
     done
 fi
 
diff --git a/git/gitconfig b/git/gitconfig
index 5207efce..dda53dcf 100644
--- a/git/gitconfig
+++ b/git/gitconfig
@@ -6,8 +6,8 @@
 #
 #     GIT_AUTHOR_NAME='Tom Ryder'
 #     GIT_AUTHOR_EMAIL='tom@sanctum.geek.nz'
-#     GIT_COMMITTER_NAME=$GIT_AUTHOR_NAME
-#     GIT_COMMITTER_EMAIL=$GIT_AUTHOR_EMAIL
+#     GIT_COMMITTER_NAME="$GIT_AUTHOR_NAME"
+#     GIT_COMMITTER_EMAIL="$GIT_AUTHOR_EMAIL"
 #     export GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL GIT_COMMITTER_NAME GIT_COMMITTER_EMAIL
 #
 [advice]
diff --git a/sh/profile b/sh/profile
index 813fb7cc..14b0a56b 100644
--- a/sh/profile
+++ b/sh/profile
@@ -15,8 +15,8 @@ export PATH
 
 # Load all supplementary scripts in ~/.profile.d
 if [ -d "$HOME/.profile.d" ]; then
-    for file in $HOME/.profile.d/*; do
-        . $file
+    for file in "$HOME/.profile.d"/*; do
+        . "$file"
     done
 fi
 
diff --git a/sh/profile.d/keychain.sh b/sh/profile.d/keychain.sh
index 08f1a4cc..a3659c60 100644
--- a/sh/profile.d/keychain.sh
+++ b/sh/profile.d/keychain.sh
@@ -1,11 +1,11 @@
 # ssh-askpass setup
 if command -v ssh-askpass >/dev/null 2>&1; then
-    SSH_ASKPASS=$(which ssh-askpass)
+    SSH_ASKPASS="$(which ssh-askpass)"
     export SSH_ASKPASS
 fi
 
 # keychain setup
 if command -v keychain >/dev/null 2>&1; then
-    eval $(keychain --eval --ignore-missing --quiet id_dsa id_rsa id_ecsda)
+    eval "$(keychain --eval --ignore-missing --quiet id_dsa id_rsa id_ecsda)"
 fi
 
-- 
cgit v1.2.3