diff options
| author | Tom Ryder <tom@sanctum.geek.nz> | 2015-10-21 13:08:09 +1300 |
|---|---|---|
| committer | Tom Ryder <tom@sanctum.geek.nz> | 2015-10-21 13:08:09 +1300 |
| commit | dcfc80aaa112498498d93bae3ae0eb2088244c47 (patch) | |
| tree | 889854ba1c96f1c86465da1bbd5cc87f0c8d4b9f /bash/bashrc.d/vr.bash | |
| parent | Handle spaces correctly in completions (diff) | |
| download | dotfiles-dcfc80aaa112498498d93bae3ae0eb2088244c47.tar.gz dotfiles-dcfc80aaa112498498d93bae3ae0eb2088244c47.zip | |
Tidy up completion considerably; no more compgen
* Remove all instances of compgen; for filename completion it's quite
broken as it relies on implicit wordsplitting in array context, and
doesn't have an option to print with a null delimiter; replaced with
manual for/while loops instead
* Add IFS= to while/read loops over filenames
* Use "dirname/s" instead of "dir/s" variables to avoid keyword
collisions and for clarity
* Remove some unnecessary variables
* Use shorter syntax for loop exit conditions
* Move completion options into functions where applicable rather than
having them on the completion definition itself
Diffstat (limited to 'bash/bashrc.d/vr.bash')
| -rw-r--r-- | bash/bashrc.d/vr.bash | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/bash/bashrc.d/vr.bash b/bash/bashrc.d/vr.bash index a8d836a3..3eb1fbdd 100644 --- a/bash/bashrc.d/vr.bash +++ b/bash/bashrc.d/vr.bash @@ -37,8 +37,8 @@ vr() { return fi - # If we have a .svn dir, iterate upwards until we find an ancestor that - # doesn't; hopefully that's the root + # If we have a .svn directory, iterate upwards until we find an ancestor + # that doesn't; hopefully that's the root if [[ -d $path/.svn ]] ; then local search search=$path |