diff options
| author | Tom Ryder <tom@sanctum.geek.nz> | 2016-07-15 00:34:48 +1200 |
|---|---|---|
| committer | Tom Ryder <tom@sanctum.geek.nz> | 2016-07-15 00:40:37 +1200 |
| commit | 8947c4c99f4c1ad92f23e59e84b224cf35e4ff81 (patch) | |
| tree | 70718ad01791f2ca67133376252cf69a693b14ea /bash/bashrc.d/cd.bash | |
| parent | Terser `read -rd ''` idiom (diff) | |
| download | dotfiles-8947c4c99f4c1ad92f23e59e84b224cf35e4ff81.tar.gz dotfiles-8947c4c99f4c1ad92f23e59e84b224cf35e4ff81.zip | |
Quote expansions within parameter expansions
I made the incorrect assumption that it was safe not to do this;
expansions that include glob characters, for example, can cause
problems.
Diffstat (limited to 'bash/bashrc.d/cd.bash')
| -rw-r--r-- | bash/bashrc.d/cd.bash | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bash/bashrc.d/cd.bash b/bash/bashrc.d/cd.bash index 8557b8c9..04de96d5 100644 --- a/bash/bashrc.d/cd.bash +++ b/bash/bashrc.d/cd.bash @@ -20,7 +20,7 @@ cd() { done if (($# == 2)) ; then if [[ $PWD == *"$1"* ]] ; then - builtin cd "${opts[@]}" -- "${PWD/$1/$2}" + builtin cd "${opts[@]}" -- "${PWD/"$1"/"$2"}" else printf 'bash: %s: could not replace substring\n' \ "$FUNCNAME" >&2 |