Tidy up completion considerably; no more compgen

*   Remove all instances of compgen; for filename completion it's quite
    broken as it relies on implicit wordsplitting in array context, and
    doesn't have an option to print with a null delimiter; replaced with
    manual for/while loops instead
*   Add IFS= to while/read loops over filenames
*   Use "dirname/s" instead of "dir/s" variables to avoid keyword
    collisions and for clarity
*   Remove some unnecessary variables
*   Use shorter syntax for loop exit conditions
*   Move completion options into functions where applicable rather than
    having them on the completion definition itself

1 files changed, 1 insertions, 1 deletions

diff --git a/bash/bashrc.d/apf.bash b/bash/bashrc.d/apf.bash
index af759577..01b38437 100644
--- a/bash/bashrc.d/apf.bash
+++ b/bash/bashrc.d/apf.bash
@@ -85,7 +85,7 @@ apf() {
     # Read all the null-delimited arguments from the file
     local -a args
     local arg
-    while read -d '' -r arg ; do
+    while IFS= read -d '' -r arg ; do
         args=("${args[@]}" "$arg")
     done < "$argfile"