diff options
author | Tom Ryder <tom@sanctum.geek.nz> | 2016-08-18 12:02:19 +1200 |
---|---|---|
committer | Tom Ryder <tom@sanctum.geek.nz> | 2016-08-18 12:02:19 +1200 |
commit | 423e47360e2bf0a905929d1dfe0c7ecd40c6b243 (patch) | |
tree | 1e02dc4dfd471fc6771a562db1683ab85327a91a | |
parent | Use consistent syntax for sh source loops (diff) | |
download | dotfiles-423e47360e2bf0a905929d1dfe0c7ecd40c6b243.tar.gz dotfiles-423e47360e2bf0a905929d1dfe0c7ecd40c6b243.zip |
Use explicit -n test within [[ ]]
Bash doesn't require it, but there's no real advantage to it and it's a
better habit for complying with e.g. pdksh, which does
-rw-r--r-- | bash/bash_completion.d/man.bash | 4 | ||||
-rw-r--r-- | bash/bashrc | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/bash/bash_completion.d/man.bash b/bash/bash_completion.d/man.bash index f1762a01..d2499c0a 100644 --- a/bash/bash_completion.d/man.bash +++ b/bash/bash_completion.d/man.bash @@ -35,8 +35,8 @@ _man() { # Iterate through the manual page paths and add every manual page we find for manpath in "${manpaths[@]}" ; do - [[ $manpath ]] || continue - if [[ $section ]] ; then + [[ -n $manpath ]] || continue + if [[ -n $section ]] ; then for page in "$manpath"/"$subdir"/"$word"*."$section"?(.[glx]z|.bz2|.lzma|.Z) ; do pages[${#pages[@]}]=$page done diff --git a/bash/bashrc b/bash/bashrc index 0e1859ad..220ecec6 100644 --- a/bash/bashrc +++ b/bash/bashrc @@ -102,7 +102,7 @@ fi # If COMP_WORDBREAKS has a value, strip all colons from it; this allows # completing filenames correctly, since an unquoted colon is not a syntactic # character: <http://tiswww.case.edu/php/chet/bash/FAQ> (E13) -if [[ $COMP_WORDBREAKS ]] ; then +if [[ -n $COMP_WORDBREAKS ]] ; then COMP_WORDBREAKS=${COMP_WORDBREAKS//:} fi |